Skip to content

fix: Fixed NavigationView FrameMargin being overwritten by OnTitleBarChanged. #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Koichi-Kobayashi wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Fixed NavigationView FrameMargin being overwritten by OnTitleBarChanged. #1517

Koichi-Kobayashi wants to merge 3 commits into from
+1 −3

Conversation

@Koichi-Kobayashi
Copy link
Contributor

@Koichi-Kobayashi Koichi-Kobayashi commented Aug 24, 2025

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • Even if you set the FrameMargin of ui:NavigationView to 0, FrameMarginDefault is always set.
  • Setting FrameMarginDefault where the FrameMargin dependency property is registered works fine.
OverwriteFrameMargin_2025-08-24_12h58_28

Other information

@github-actions github-actions bot added controls Changes to the appearance or logic of custom controls. PR Pull request navigation Changes to navigation related controls. dotnet release labels Aug 24, 2025
@pomianowski pomianowski changed the title Fixed FrameMargin being overwritten by OnTitleBarChanged. fix: Fixed FrameMargin being overwritten by OnTitleBarChanged. Nov 7, 2025
@pomianowski pomianowski changed the title fix: Fixed FrameMargin being overwritten by OnTitleBarChanged. fix: Fixed NavigationView FrameMargin being overwritten by OnTitleBarChanged. Nov 7, 2025
pomianowski
pomianowski previously approved these changes Nov 7, 2025
View reviewed changes
Nuklon
Nuklon suggested changes Jan 9, 2026
View reviewed changes
Copy link
Collaborator

@Nuklon Nuklon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the UI, the navigation view is now rendered completely at the top of the window. You can check this with the gallery app.

--> Just a case of removing FrameMargin="0" from Gallery MainWindow, so this would need to be added to the PR.

@pomianowski pomianowski dismissed their stale review January 10, 2026 14:42

breaking changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pomianowski pomianowski pomianowski left review comments

+1 more reviewer

@Nuklon Nuklon Nuklon requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

controls Changes to the appearance or logic of custom controls. dotnet navigation Changes to navigation related controls. PR Pull request release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Koichi-Kobayashi @pomianowski @Nuklon