Correct typo in Class() function: simga8() -> sigma8()#636
Open
sbird wants to merge 1 commit intolesgourg:masterfrom
Open
Correct typo in Class() function: simga8() -> sigma8()#636sbird wants to merge 1 commit intolesgourg:masterfrom
sbird wants to merge 1 commit intolesgourg:masterfrom
Conversation
This is new in v3.3.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the functions were reorganised for v3.3.2, sigma8() was accidentally renamed to simga8(), and sigma8_cb was renamed to simga8_cb. Fix the typo by renaming them back.
This is obviously a bit unfortunate as it breaks some large-scale structure users!
Thanks!
I'm not sure why the tests didn't catch this - it looks like this is tested in python/test_class.py.