This repository was archived by the owner on Oct 2, 2020. It is now read-only.
Add missing arguments to loadFile and loadFileSync#25
Open
parshap wants to merge 2 commits intoless:masterfrom
NerdWallet:fix-missing-args
Open
Add missing arguments to loadFile and loadFileSync#25parshap wants to merge 2 commits intoless:masterfrom NerdWallet:fix-missing-args
parshap wants to merge 2 commits intoless:masterfrom
NerdWallet:fix-missing-args
Conversation
Less's import-manager.js calls loadFile with a "callback" argument [1] and file-manager.js calls loadFileSync with an "encoding" argument [2], without which operating in synchronous mode (using the syncImport less option) is broken. [1] https://github.com/less/less.js/blob/4a0026ebf6d4c783365d3701ac796c18dcc9d30f/lib/less/import-manager.js#L119 [2] https://github.com/less/less.js/blob/4a0026ebf6d4c783365d3701ac796c18dcc9d30f/lib/less-node/file-manager.js#L32
When running in sync mode (syncImport option), loadFile should call the callback instead of returning a promise. This change implements logic similar to [1]. [1] https://github.com/less/less.js/blob/49cbe520f6b38b4b8797dcba491501c0c461c7f5/lib/less-node/file-manager.js#L31
parshap
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using
less.renderin synchronous mode (using thesyncImportless option) to preprocess css module files using css-modules-require-hook. However, when using this plugin, less synchronous mode stops working -- the callback passed toless.renderis never called.After some digging, I found that this is because less's
import-manager.jscallsloadFilewith acallbackargument (see here) andfile-manager.jscallsloadFileSyncwith anencodingargument (see here). The FileManager implemented in this module does not forward these arguments along, causing the calls to fail.This PR fixes this module when using
less.renderin synchronous mode by adding the missing arguments.