Add shiftRowsUp/shiftRowsDown methods#127
Open
igorinov wants to merge 2 commits intolessthanoptimal:SNAPSHOTfrom
Open
Add shiftRowsUp/shiftRowsDown methods#127igorinov wants to merge 2 commits intolessthanoptimal:SNAPSHOTfrom
igorinov wants to merge 2 commits intolessthanoptimal:SNAPSHOTfrom
Conversation
Owner
lessthanoptimal
left a comment
There was a problem hiding this comment.
Over all looks good. One documentation comment. Could you remind me what the application is again?
| } | ||
|
|
||
| /** | ||
| * Shifts all rows down by the specified number of places |
Owner
There was a problem hiding this comment.
Could you mention what happens to the rows that are now unoccupied?
Owner
|
Could you also run |
Author
It was added for fixed lag and fixed interval smoother. Recently I optimized my smoother implementation to avoid shifts, but they could be useful in other projects. |
Owner
|
CI still isn't passing. Did you try running |
Author
|
Owner
|
weird. Could you try this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These row shifting functions were created for an experimental implementation of fixed lag smoother based on Kalman filter.
The shift functions were optimized out of that filter implementation later, but they may be useful for some other projects.