Deprecate rows/cols in favour of getRows/getColumns#190
Open
JozsefKutas wants to merge 8 commits intolessthanoptimal:SNAPSHOTfrom
Open
Deprecate rows/cols in favour of getRows/getColumns#190JozsefKutas wants to merge 8 commits intolessthanoptimal:SNAPSHOTfrom
JozsefKutas wants to merge 8 commits intolessthanoptimal:SNAPSHOTfrom
Conversation
JozsefKutas
force-pushed
the
rename-rows-cols
branch
from
30bd3cc to
50ed7b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces
rows/colswithgetRows/getColumnsto be consistent with the rest of theSimpleMatrixAPI. All other methods (exceptgetNumCols) use columns rather than cols. All other getters/setters (exceptdiag/zero) include a verb in the name to convery the action (get/extract/set/insertInto).I understand there's a tradeoff between API consistency and avoiding breaking the existing API, so this PR is just a suggestion.
This also fixes the unit test for
colswhich was previously just a duplicate of the unit test forrows.This PR follows from #188 - the two overlap, so it didn't seem to make sense to separate them. I can separate this if there are problems with #188.