Skip to content

Conversation

@soun997
Copy link
Contributor

@soun997 soun997 commented Oct 15, 2025

이슈 번호 (#342)

요약

  • 앱에서 요구하는 형식에 맞게 API 응답 필드 변경

@soun997 soun997 requested a review from Copilot October 15, 2025 07:52
@soun997 soun997 self-assigned this Oct 15, 2025
@soun997 soun997 added the fix release 수정 관련 이슈 label Oct 15, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies API response fields for Calendar and Goal domains to support improved app structure. The changes involve restructuring response DTOs by removing some fields from certain responses and adding others.

  • Removed categoryId and calendarId from WeeklyGoalResponse while adding week field
  • Added categoryId to CalendarResponse and calendarId to WeeklyGoalDetailsResponse
  • Simplified MonthlyGoalListResponse by removing categoryId and calendarId fields

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
CustomWeeklyGoalRepository.java Enhanced query to fetch additional related entities (category, relatedMonthlyGoal)
WeeklyGoalResponse.java Restructured response fields: removed categoryId/calendarId, added week field
WeeklyGoalDetailsResponse.java Added calendarId field to detailed response
MonthlyGoalListResponse.java Simplified response by removing categoryId and calendarId fields
CalendarResponse.java Added categoryId field to calendar response

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@soun997 soun997 merged commit 6e53f41 into develop Oct 15, 2025
3 checks passed
@soun997 soun997 linked an issue Oct 15, 2025 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix release 수정 관련 이슈

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fix] Goal 도메인 API 응답 필드 변경

2 participants