Skip to content

[P073] Bugfix: Display stays blank after upgrade without settings-save #5475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TD-er merged 4 commits into from
Jan 21, 2026
Merged

[P073] Bugfix: Display stays blank after upgrade without settings-save #5475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08f0b59
[P073] Bugfix: Display stays blank after upgrade without settings-save
tonhuisman Jan 12, 2026
24e3957
Merge branch 'mega' of https://github.com/letscontrolit/ESPEasy into …
tonhuisman Jan 17, 2026
4f85fd6
[P073] Revert to regular GPIO for TM1637 on ESP8266
tonhuisman Jan 17, 2026
2e46e65
[P073] Minor code reduction (eliminate unneeded variables)
tonhuisman Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 28 additions & 14 deletions src/_P073_7DGT.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@
//

/** History
* 2026-01-17 tonhuisman: Revert to using 'regular' Arduino GPIO functions for TM1637 displays on ESP8266
* 2026-01-12 tonhuisman: Fix initialization of number of digits when upgrading to 20260108 build,
* formatted source with new Uncrustify config
* 2024-09-28 tonhuisman: Switch to using DIRECT_PIN_IO, to get better timing-accuracy for TM1637 displays
* 2024-09-27 tonhuisman: Add option to flash dot on second digit instead of the colon for blinking time
* 2024-08-24 tonhuisman: Add compiletime define P073_USE_74HC595_OVERRIDE that, when, set to 1, allows 74HC595 displays to be included
Expand Down Expand Up @@ -96,12 +99,13 @@

# include "src/PluginStructs/P073_data_struct.h"


boolean Plugin_073(uint8_t function, struct EventStruct *event, String& string) {
boolean success = false;

switch (function) {
case PLUGIN_DEVICE_ADD: {
switch (function)
{
case PLUGIN_DEVICE_ADD:
{
auto& dev = Device[++deviceCount];
dev.Number = PLUGIN_ID_073;
dev.Type = DEVICE_TYPE_TRIPLE;
Expand All @@ -113,13 +117,15 @@ boolean Plugin_073(uint8_t function, struct EventStruct *event, String& string)
break;
}

case PLUGIN_GET_DEVICENAME: {
case PLUGIN_GET_DEVICENAME:
{
string = F(PLUGIN_NAME_073);
break;
}

# if P073_SCROLL_TEXT || P073_USE_74HC595
case PLUGIN_SET_DEFAULTS: {
case PLUGIN_SET_DEFAULTS:
{
# if P073_SCROLL_TEXT
P073_CFG_SCROLLSPEED = 10; // Default 10 * 0.1 sec scroll speed
# endif // if P073_SCROLL_TEXT
Expand All @@ -134,7 +140,8 @@ boolean Plugin_073(uint8_t function, struct EventStruct *event, String& string)
}
# endif // if P073_SCROLL_TEXT || P073_USE_74HC595

case PLUGIN_WEBFORM_LOAD: {
case PLUGIN_WEBFORM_LOAD:
{
addFormNote(F("TM1637: 1st=CLK-Pin, 2nd=DIO-Pin"));
addFormNote(F("MAX7219: 1st=DIN-Pin, 2nd=CLK-Pin, 3rd=CS-Pin"));
# if P073_USE_74HC595
Expand All @@ -151,7 +158,7 @@ boolean Plugin_073(uint8_t function, struct EventStruct *event, String& string)
};
constexpr size_t optionCount = NR_ELEMENTS(displtype);
const FormSelectorOptions selector(optionCount, displtype);
selector.addFormSelector(F("Display Type"), F("displtype"), PCONFIG(0));
selector.addFormSelector(F("Display Type"), F("displtype"), P073_CFG_DISPLAYTYPE);
}
# if P073_USE_74HC595

Expand Down Expand Up @@ -258,7 +265,8 @@ boolean Plugin_073(uint8_t function, struct EventStruct *event, String& string)
break;
}

case PLUGIN_WEBFORM_SAVE: {
case PLUGIN_WEBFORM_SAVE:
{
P073_CFG_DISPLAYTYPE = getFormItemInt(F("displtype"));
P073_CFG_OUTPUTTYPE = getFormItemInt(F("displout"));
P073_CFG_BRIGHTNESS = getFormItemInt(F("brightness"));
Expand Down Expand Up @@ -292,12 +300,14 @@ boolean Plugin_073(uint8_t function, struct EventStruct *event, String& string)
break;
}

case PLUGIN_EXIT: {
case PLUGIN_EXIT:
{
success = true;
break;
}

case PLUGIN_INIT: {
case PLUGIN_INIT:
{
initPluginTaskData(event->TaskIndex, new (std::nothrow) P073_data_struct());
P073_data_struct *P073_data =
static_cast<P073_data_struct *>(getPluginTaskData(event->TaskIndex));
Expand All @@ -317,7 +327,8 @@ boolean Plugin_073(uint8_t function, struct EventStruct *event, String& string)
break;
}

case PLUGIN_WRITE: {
case PLUGIN_WRITE:
{
P073_data_struct *P073_data =
static_cast<P073_data_struct *>(getPluginTaskData(event->TaskIndex));

Expand All @@ -327,7 +338,8 @@ boolean Plugin_073(uint8_t function, struct EventStruct *event, String& string)
break;
}

case PLUGIN_ONCE_A_SECOND: {
case PLUGIN_ONCE_A_SECOND:
{
P073_data_struct *P073_data =
static_cast<P073_data_struct *>(getPluginTaskData(event->TaskIndex));

Expand All @@ -339,7 +351,8 @@ boolean Plugin_073(uint8_t function, struct EventStruct *event, String& string)
}

# if P073_SCROLL_TEXT
case PLUGIN_TEN_PER_SECOND: {
case PLUGIN_TEN_PER_SECOND:
{
P073_data_struct *P073_data =
static_cast<P073_data_struct *>(getPluginTaskData(event->TaskIndex));

Expand All @@ -353,7 +366,8 @@ boolean Plugin_073(uint8_t function, struct EventStruct *event, String& string)

# if P073_USE_74HC595

case PLUGIN_TASKTIMER_IN: {
case PLUGIN_TASKTIMER_IN:
{
P073_data_struct *P073_data =
static_cast<P073_data_struct *>(getPluginTaskData(event->TaskIndex));

Expand Down
Loading