Update go-sql-driver/mysql to v1.7.1 #6976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgporada
approved these changes
Jul 5, 2023
beautifulentropy
approved these changes
Jul 11, 2023
Member
|
@pgporada it looks like sysown/proxysql@41211f5, which shipped in v2.5.3, adds some additional variables that could get caught up in the use of multiple SET syntax in this update. I believe that SRE has already deployed this version, but in case they haven't we should make them aware of this. |
Member
|
They've been using the slow query logging successfully since June 29th. |
Merged
aarongable
pushed a commit
that referenced
this pull request
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update pulls in changes that we contributed upstream, which should smooth interactions between Boulder and ProxySQL.
Release notes: https://github.com/go-sql-driver/mysql/releases/tag/v1.7.1
Changelog: go-sql-driver/mysql@v1.5.0...v1.7.1
Relevant change: go-sql-driver/mysql#1402
DO NOT MERGE until we SRE is on board with monitoring this change