test: on migration error, don't try to auto-recover #8545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, in create_db.sh on any migration failure we'd drop tables and re-create them. However, this had a bug - it didn't respect SKIP_CREATE. Also, it doesn't work for Vitess, where we create tables outside of create_db.sh. In the interests of simplification, simply remove this fallback and give the user instructions on how to proceed. Also, clean up the MYSQL_CONTAINER variable. We always run MySQL / MariaDB in a container.
aarongable
reviewed
Jan 7, 2026
| local dbconn="${2}" | ||
| create_script="drop database if exists \`${db}\`; create database if not exists \`${db}\`;" | ||
| mysql ${dbconn} -e "${create_script}" || exit_err "unable to create ${db}" | ||
| mysql ${dbconn} -e "${create_script}" || exit_err "unable to create ${db} on ${cbconn}" |
Contributor
There was a problem hiding this comment.
typo?
Suggested change
| mysql ${dbconn} -e "${create_script}" || exit_err "unable to create ${db} on ${cbconn}" | |
| mysql ${dbconn} -e "${create_script}" || exit_err "unable to create ${db} on ${dbconn}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, in create_db.sh on any migration failure we'd drop tables and re-create them. However, this had a bug - it didn't respect SKIP_CREATE. Also, it doesn't work for Vitess, where we create tables outside of create_db.sh. In the interests of simplification, simply remove this fallback and give the user instructions on how to proceed.
Also, clean up the MYSQL_CONTAINER variable. We always run MySQL / MariaDB in a container.
The new code path echoes the error from
sql-migrate(which includes the string "Migration failed"), so I removed some redundant messages.