fix: resolve ESM/CJS conflict by renaming silent-npx.js to silent-npx.cjs#21
Closed
scrossle wants to merge 4 commits intoletta-ai:mainfrom
Closed
fix: resolve ESM/CJS conflict by renaming silent-npx.js to silent-npx.cjs#21scrossle wants to merge 4 commits intoletta-ai:mainfrom
scrossle wants to merge 4 commits intoletta-ai:mainfrom
Conversation
Updated the command paths in hooks.json from silent-npx.js to silent-npx.cjs.
6 tasks
Contributor
Author
|
Superseded by #22 which uses a PseudoConsole (ConPTY) approach instead of the simple npx wrapper fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20
Issue
The
silent-npx.jsfile uses CommonJSrequire()syntax, but sincepackage.jsondeclares"type": "module", Node.js treats all.jsfiles as ES modules. This causes the error:All hooks fail because they all go through the
silent-npx.jswrapper:Solution
hooks/silent-npx.js→hooks/silent-npx.cjshooks/hooks.jsonThe
.cjsextension forces Node.js to parse the file as CommonJS, regardless of the"type": "module"setting inpackage.json.