Performance: Cache expensive regex compilation#86
Open
mark-cooke wants to merge 1 commit intoleukipp:mainfrom
Open
Performance: Cache expensive regex compilation#86mark-cooke wants to merge 1 commit intoleukipp:mainfrom
mark-cooke wants to merge 1 commit intoleukipp:mainfrom
Conversation
The regexes for class and name were compiled for every check of a window Now they are both cached to save time and memory churn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @leukipp - Happy New Year!
A PR for a small change to improve performance.
The regexes for class and name were compiled every time a window was checked if it was ignored/tracked - This PR caches them to save processing time and memory churn.