Skip to content

fix: expose display brightness without display status command #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CoRfr wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: expose display brightness without display status command #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions js/hardware.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,10 +298,13 @@ const checkSupport = () => {
const brightnessPath = !!HARDWARE.display.brightness.path && !!HARDWARE.display.brightness.value.max;
const brightnessCommand = !!HARDWARE.display.brightness.command && !!HARDWARE.display.brightness.value.max;

const hasBrightness = sudo && (brightnessPath || brightnessCommand);

return {
batteryLevel: batteryPath,
displayStatus: statusPath && statusCommand,
displayBrightness: sudo && statusPath && statusCommand && (brightnessPath || brightnessCommand),
// Assume displayStatus is true if brightness works but status command doesn't (e.g., cage)
displayStatus: (statusPath && statusCommand) || hasBrightness,
displayBrightness: hasBrightness,
keyboardVisibility: keyboard,
audioVolume: audioDevice,
sudoRights: sudo,
Expand Down Expand Up @@ -576,6 +579,10 @@ const getDisplayStatus = () => {
}
break;
}
// If no status command but brightness is supported, assume display is on
if (HARDWARE.support.displayBrightness) {
return "ON";
}
return null;
};

Expand Down Expand Up @@ -608,6 +615,10 @@ const setDisplayStatus = (status, callback = null) => {
case "xset":
execAsyncCommand("xset", ["dpms", "force", status.toLowerCase()], callback);
break;
default:
// No display status command available, just call callback
if (typeof callback === "function") callback(null, null);
break;
}
};

Expand Down