Skip to content

Add fallback image for missing images #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add fallback image for missing images #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion task-launcher/src/tasks/matrix-reasoning/trials/instructions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const instructions = instructionData.map((data) => {


<img
src=${mediaAssets.images[data.image]}
src=${mediaAssets.images[data.image] || mediaAssets.images.imageNotFoundFallback}
alt='Instruction graphic'
/>
</div>`;
Expand Down
4 changes: 2 additions & 2 deletions task-launcher/src/tasks/memory-game/trials/instructions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,12 @@ export const instructions = instructionData.map((data) => {
</div>
<div class="lev-stim-content-x-3">
${
data.video
data.video && mediaAssets.video[data.video]
? `<video class='instruction-video-small' autoplay loop>
<source src=${mediaAssets.video[data.video]} type='video/mp4'>
</video>`
: `<img
src=${mediaAssets.images[data.image as string]}
src=${mediaAssets.images[data.image as string] || mediaAssets.images.imageNotFoundFallback}
alt='Instruction graphic'
/>`
}
Expand Down
26 changes: 17 additions & 9 deletions task-launcher/src/tasks/mental-rotation/trials/instructions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,14 @@ export const videoInstructionsFit = {
<button id="${replayButtonHtmlId}" class="replay">
${replayButtonSvg}
</button>
<video class="instruction-video" autoplay>
<source src=${mediaAssets.video.mentalRotationExampleFit} type="video/mp4"/>
Your browser does not support the video tag.
</video>
${
mediaAssets.video.mentalRotationExampleFit ?
`<video class="instruction-video" autoplay>
<source src=${mediaAssets.video.mentalRotationExampleFit} type="video/mp4"/>
Your browser does not support the video tag.
</video>` :
`<img src=${mediaAssets.images.imageNotFoundFallback} class="instruction-video" />`
}
</div>
`;
},
Expand Down Expand Up @@ -81,10 +85,14 @@ export const videoInstructionsMisfit = {
<button id="${replayButtonHtmlId}" class="replay">
${replayButtonSvg}
</button>
<video class="instruction-video" autoplay>
<source src=${mediaAssets.video.mentalRotationExampleMisfit} type="video/mp4"/>
Your browser does not support the video tag.
</video>
${
mediaAssets.video.mentalRotationExampleMisfit ?
`<video class="instruction-video" autoplay>
<source src=${mediaAssets.video.mentalRotationExampleMisfit} type="video/mp4"/>
Your browser does not support the video tag.
</video>` :
`<img src=${mediaAssets.images.imageNotFoundFallback} class="instruction-video" />`
}
</div>
`;
},
Expand Down Expand Up @@ -123,7 +131,7 @@ export const imageInstructions = {
<button id="${replayButtonHtmlId}" class="replay">
${replayButtonSvg}
</button>
<img src=${mediaAssets.images.mentalRotationExample} class="instruction-video" />
<img src=${mediaAssets.images.mentalRotationExample || mediaAssets.images.imageNotFoundFallback} class="instruction-video" />
</div>
`;
},
Expand Down
Loading