Skip to content

Conversation

@kkrime
Copy link

@kkrime kkrime commented Aug 21, 2025

Added code to automatically close blame window if :Gitsigns blame command is entered and

  1. the blame widow for the current buffer is already open
  2. current widnow is a git blame window

@kkrime
Copy link
Author

kkrime commented Aug 21, 2025

@lewis6991 CI / test is failing, but I'm not sure it's to do with my code, it fails when I run make test on main locally

@kkrime kkrime marked this pull request as draft August 22, 2025 20:33
@kkrime kkrime marked this pull request as ready for review August 23, 2025 09:50
@noirbizarre
Copy link

CI is failing because your commits are not respecting conventional commit.
Squash your commits into a single commit feat(blame): blame window toggle and it should be good.
Can't wait to have this merged!! Thanks 🙏🏼

@lewis6991 lewis6991 closed this Jan 9, 2026
@noirbizarre
Copy link

Hi @lewis6991

Is it closed because the commit message was never fixed or because you are not interested in this and won't merge any PR on this ?

(I apologize for the ping, but I just want to know if it's OK to work on another PR to add blame window toggle or not. I prefer asking before.)

@lewis6991
Copy link
Owner

commit message and wasn't quite happy with the implementation. CONTRIBUTING.md says no new features so don't expect any PR's to get merged, though sometimes I can be persuaded.

@noirbizarre
Copy link

OK, makes sense. 👍🏼

It's easy enough to make this with a after/ftplugin/gitsigns-blame.lua

Anyway, thanks for this great plugin!! 🙏🏼

@kkrime
Copy link
Author

kkrime commented Jan 9, 2026

@lewis6991 @noirbizarre I squashed the commits, can this be merged now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants