fix(word_diff): "No newline at eof" should show once for single hunk#1477
Merged
lewis6991 merged 1 commit intolewis6991:mainfrom Feb 10, 2026
Merged
fix(word_diff): "No newline at eof" should show once for single hunk#1477lewis6991 merged 1 commit intolewis6991:mainfrom
lewis6991 merged 1 commit intolewis6991:mainfrom
Conversation
Problem:
When use `require('gitsigns.diff_int').run_diff` I find
"no_nl_at_eof=true" can be set for both removed/added hunk, this make
"\ No newline at eof" appear multiple times.
Solution:
* Only show no_nl_at_eof when it changed, remove uselss +/- prefix.
* Also insert no_nl_at_eof after insert word diff to hls array
to avoid messup the hls[] array index.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When use
require('gitsigns.diff_int').run_diffI find"no_nl_at_eof=true" can be set for both removed/added hunk, this make
"\ No newline at eof" appear multiple times.
Solution:
to avoid messup the hls[] array index.