Skip to content

MSVC 2019 seems to separate <iostream> from <string> header #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

MSVC 2019 seems to separate <iostream> from <string> header #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7ec6d7
Include <ostream> if MSVC 2019 or later
denchat May 21, 2019
fb274c3
MSVC 2019 needs <string> included for to_string
denchat May 21, 2019
6b3b347
Merge branch 'master' into patch-3
lewissbaker May 28, 2019
d2245e8
trying force push
denchat Aug 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion test/doctest/doctest.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,11 @@ extern "C" __declspec(dllimport) void __stdcall DebugBreak();
// so the <iosfwd> header is used - also it is very light and doesn't drag a ton of stuff
//#include <iosfwd>
#include <ostream>
#else // _LIBCPP_VERSION
#elif (_MSC_VER >= 1920)
// MSVC 2019 removes <iostream> from <string>
// https://developercommunity.visualstudio.com/content/problem/525532/visual-studio-2019-compilation-issue.html
#include <ostream>
#else
#ifndef DOCTEST_CONFIG_USE_IOSFWD
namespace std
{
Expand Down
1 change: 1 addition & 0 deletions test/file_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#include "io_service_fixture.hpp"

#include <ostream>
#include <string>
#include "doctest/doctest.h"

TEST_SUITE_BEGIN("file");
Expand Down