Fix issue with token generation via DateTimeImmutable instead of int (dependency with lcobucci/jwt ^5.0)#1282
Open
RuslanKononov wants to merge 2 commits intolexik:3.xfrom
Open
Fix issue with token generation via DateTimeImmutable instead of int (dependency with lcobucci/jwt ^5.0)#1282RuslanKononov wants to merge 2 commits intolexik:3.xfrom
RuslanKononov wants to merge 2 commits intolexik:3.xfrom
Conversation
maxhelias
reviewed
Jul 15, 2025
maxhelias
reviewed
Jul 18, 2025
maxhelias
reviewed
Jul 21, 2025
Comment on lines
+38
to
+39
| 'iat' => $this->clock->now(), | ||
| 'nbf' => $this->clock->now(), |
Contributor
There was a problem hiding this comment.
Shouldn't these 2 entries have the same instance? Or is it irrelevant?
Author
There was a problem hiding this comment.
it's irrelevant (it was time() before) but you are right, it's more correct to make same nanoseconds time for "initialization" and "not before". maybe it help someone with unit testing
…(dependency with lcobucci/jwt ^5.0)
maxhelias
approved these changes
Jul 22, 2025
Contributor
maxhelias
left a comment
maxhelias
left a comment
There was a problem hiding this comment.
For me it's ok as the LcobucciJWSProvider class hasn't configured the clock injection either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was problem with generation of token from DTO that implement UserInterface and it was fixed via this changes.