fix(Storage): Implicitly nullable parameters are deprecated#469
Merged
bartmcleod merged 7 commits intolexik:masterfrom Apr 14, 2025
Merged
Conversation
bartmcleod
requested changes
Apr 12, 2025
bartmcleod
approved these changes
Apr 14, 2025
shakaran
added a commit
to shakaran/LexikTranslationBundle
that referenced
this pull request
Apr 15, 2025
* fix(Storage): Implicitly nullable parameters are deprecated * feat: update return types and arguments with warnings for php 8.4 * fix: import short namespaces and null applied * fix: duplicate use of transunit * fix: bump mongo extension in recent release 2.0.0 for PHP 8.4 * fix: allow several version of mongo
shakaran
deleted the
fix/implicit-nullable-parameters-deprecated-storage
branch
bartmcleod
pushed a commit
that referenced
this pull request
Jun 24, 2025
* fix: allow load base translator class from Symfony 7.1 * fix: missing line for content * fix(Storage): Implicitly nullable parameters are deprecated (#469) * fix(Storage): Implicitly nullable parameters are deprecated * feat: update return types and arguments with warnings for php 8.4 * fix: import short namespaces and null applied * fix: duplicate use of transunit * fix: bump mongo extension in recent release 2.0.0 for PHP 8.4 * fix: allow several version of mongo * fix: add base translator to test * fix: test command and translator test * fix: update mocks and base services * fix: update missing formatter * feat: improve return type objects, implicit nullable and short call with doctrine (#473) * feat: improve return type objects, implicit nullable and short call with doctrine * fix: declaration method addTranslation with interface * feat: improve declaration for TransUnit * fix: update storage interfaces * fix: improve declaration for entities, manager and model * fix: more declarations missing * fix: translation interface in getter * fix: add missing empty null in interface * fix: typos declarations * fix: add more check for storages * fix: for mongo db type documents * fix: add compatible call in transunit * fix: resolve createat as string in mongo * fix: test empty key and domain * fix: more declarations match * feat: use short class for mongo * fix: update hasTranslation as string for getLocale * fix: allow return null in add translation * fix: typo * feat: implement dockerization with documentation for testing (#474) * feat: implement dockerization with documentation for testing * feat: add Dockerfile and docker compose * feat: improve abtract doctrine storage. Superseed #468 (#475) * Add yaml extension support (#462) * feat: add missing import * feat: add param type import * feat: import file interface in storage interface * feat: update type for hydrator single column * feat: use symfony translator as base translator * feat: update test for new base translator * fix: wrong typo in testing * fix: remove base translator since not needed anymore * fix: change order loader ids * fix: prevent no initialize options by default * fix: missing init vars * fix: improve with equals canonicalizing asserts * fix: duplicate insert of messages * fix: remove useless comment --------- Co-authored-by: SosthenG <pro@sosthen.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PHP 8.4 this PR fix deprecated errors like:
Deprecated: Lexik\Bundle\TranslationBundle\Storage\StorageInterface::getTransUnitList(): Implicitly marking parameter $filters as nullable is deprecated, the explicit nullable type must be used insteadDeprecated: Lexik\Bundle\TranslationBundle\Entity\TransUnitRepository::addTranslationFilter(): Implicitly marking parameter $filters as nullable is deprecated, the explicit nullable type must be used instead