Move doctrine/doctrine-bundle requirement under require-dev #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The doctrine/doctrine-bundle seems to only be used by tests: https://github.com/search?q=repo%3Alexik%2FLexikTranslationBundle%20Doctrine%5CBundle&type=code This PR moves the requirement under require-dev so that I can install doctrine-bundle v3 in my project: ``` Problem 1 - Root composer.json requires lexik/translation-bundle ^7.3 -> satisfiable by lexik/translation-bundle[v7.3, ..., v7.3.6]. - lexik/translation-bundle[v7.3, ..., v7.3.6] require doctrine/doctrine-bundle ^2.2 -> found doctrine/doctrine-bundle[2.2.0, ..., 2.18.2] but it conflicts with your root composer.json require (^3.2). ```
Collaborator
|
@nicodemuz Not all checks pass, can you have a look maybe? |
Contributor
Author
|
@bartmcleod can you trigger the tests again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The doctrine/doctrine-bundle seems to only be used by tests: https://github.com/search?q=repo%3Alexik%2FLexikTranslationBundle%20Doctrine%5CBundle&type=code
This PR moves the requirement under require-dev so that I can install doctrine-bundle v3 in my project: