feat: Symfony 8.0 compatibility #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Migrate service configuration from XML to YAML * Resolves 13 deprecation warnings about XML format * Resources/config/services.xml → services.yaml - Update DependencyInjection to use YamlFileLoader - Update composer.json constraints to support Symfony ^7.0|^8.0 - Add TranslatorDecorator for Symfony 8 compatibility (when Translator is final) - Add DatabaseResourcesListener for event-driven resource loading This PR resolves critical deprecations that prevent the bundle from working with Symfony 8.0 while maintaining full backward compatibility with Symfony 7.x. Closes: #XXX
- Add support for finding translator service by alias or class name - Support named arguments in service definition - Improve service locator registration - Better compatibility with Symfony 8 service container
Collaborator
|
@HecFranco Thank you for your contribution, it looks promising, but the CI fails as you can see. Probably easy to fix by adding the dependency. |
Doctrine ORM requires symfony/var-exporter for LazyGhost support in PHP 8.4. This fixes the test errors: 'Symfony LazyGhost is not available'.
Contributor
Author
|
@bartmcleod It’s already been reviewed and uploaded, thanks. |
…ansUnitRepository - Improved flattening of locales array to handle both arrays of arrays and strings. - Added logic to remove duplicate locales. - Enhanced handling of MongoDB timestamp objects for createdAt and updatedAt fields in translation checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Purpose
This PR resolves critical deprecations that prevent the bundle from working with Symfony 8.0 while maintaining full backward compatibility with Symfony 7.x.
🔧 Changes
Service Configuration Migration
Resources/config/services.xml→Resources/config/services.yamlSince symfony/dependency-injection 7.4: XML configuration format is deprecatedDependencyInjection Updates
LexikTranslationExtensionto useYamlFileLoaderinstead ofXmlFileLoaderbuildTranslatorDefinition()methodComposer Constraints
^7.0|^8.0:symfony/assetsymfony/formsymfony/framework-bundlesymfony/security-csrfsymfony/translationsymfony/twig-bundlesymfony/validatorsymfony/yamlTranslator Compatibility
TranslatorDecoratorclass for Symfony 8 compatibility (when Translator is final)lexik_translation.translatorcontinues to work as beforeEvent-Driven Resource Loading
DatabaseResourcesListenerfor event-driven database resource loading✅ Testing
📝 Breaking Changes
None - This PR is fully backward compatible.
🔗 Related Issues
Fixes deprecations for Symfony 8.0 compatibility.
📚 Documentation