feat: Modernize codebase with PHP 8.1+ attributes #495
+309
−142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Commands: Replace setName() with #[AsCommand] attributes * ExportTranslationsCommand * ImportTranslationsCommand - Controllers: Replace YAML routing with #[Route] attributes * TranslationController * RestController - Doctrine Entities: Migrate XML mappings to PHP attributes * Entity/Translation, TransUnit, File - Doctrine Models: Migrate XML mappings to PHP attributes * Model/Translation, TransUnit, File - Update RegisterMappingPass to support attribute driver All changes maintain backward compatibility and follow Symfony best practices for PHP 8.1+. Refs: #XXX
Collaborator
|
@HecFranco The builds on this one don't pass either, maybe the same thing as your previous PR, which was successfully merged |
- Introduced a new protected property `$file` in the Translation model. - Added setter `setFile()` and getter `getFile()` methods for managing the file property. This change enhances the Translation model by allowing the association of a file with each translation instance.
- Added a custom bridge network `lexik_translation_network` for service isolation. - Updated `lexik_translation`, `mysql`, and `mongo` services to use the new network. - Set environment variables for the `lexik_translation` service to enhance configuration. These changes improve the Docker setup for the translation service, ensuring better network management and service communication.
Contributor
Author
|
@bartmcleod It’s already been reviewed and uploaded, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Purpose
This PR modernizes the codebase by replacing deprecated annotations and YAML configurations with PHP 8.1+ attributes, following Symfony best practices.
🔧 Changes
Commands
setName()method with#[AsCommand]attributesExportTranslationsCommand: Addedname,description, andhelpattributesImportTranslationsCommand: Addedname,description, andhelpattributesControllers
#[Route]attributesTranslationController: All routes now use#[Route]attributesRestController: All API routes now use#[Route]attributesResources/config/routing.yml(now usestype: attribute)Doctrine Entities
Entity/Translation: Uses#[ORM\Entity],#[ORM\Column],#[ORM\ManyToOne], etc.Entity/TransUnit: Uses#[ORM\Entity],#[ORM\Column],#[ORM\OneToMany], etc.Entity/File: Uses#[ORM\Entity],#[ORM\Column], etc.Doctrine Models
Model/Translation: Uses#[ORM\MappedSuperclass]with attributesModel/TransUnit: Uses#[ORM\MappedSuperclass]with attributesModel/File: Uses#[ORM\MappedSuperclass]with attributesDoctrine Mapping Pass
RegisterMappingPassto support AttributeDriver✅ Testing
📝 Breaking Changes
None - All changes are internal and maintain backward compatibility.
🔗 Related Issues
Modernizes codebase for PHP 8.1+ and Symfony best practices.
📚 Documentation