refactor: Improve code quality with type hints and modern PHP #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add type hints and return types to Managers * FileManager, LocaleManager, TransUnitManager - Improve Exporters with type hints * ExporterCollector, JsonExporter, PhpExporter, XliffExporter, YamlExporter - Add type hints to Utilities * DataGridFormatter, DataGridRequestHandler, StatsAggregator - Improve Loaders, Form Handlers, Storage, and Event Dispatchers * DatabaseLoader, TransUnitFormHandler, DoctrineORMListener, CleanTranslationCacheListener All changes are internal improvements that enhance type safety and maintainability without affecting public API. Refs: #XXX
Collaborator
|
@HecFranco How come @nowo-tech can close this and has control over the head repository? You put a lot of work into this. Can you clarify what is happening and whether we should still try to incorporate your changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Purpose
This PR improves code quality across the codebase by adding type hints, return types, and modern PHP features without affecting the public API.
🔧 Changes
Managers
FileManager: Improved type safety for file operationsLocaleManager: Better type checking for locale managementTransUnitManager: Enhanced type safety for translation unitsExporters
ExporterCollector: Better type checking for exporter collectionJsonExporter: Type-safe JSON exportPhpExporter: Type-safe PHP exportXliffExporter: Type-safe XLIFF exportYamlExporter: Type-safe YAML exportUtilities
DataGridFormatter: Better type checking for grid formattingDataGridRequestHandler: Type-safe request handlingStatsAggregator: Improved type safety for statisticsLoaders, Handlers, Storage, Events
DatabaseLoader: Type-safe database loadingTransUnitFormHandler: Better form handling typesDoctrineORMListener: Type-safe event listeningCleanTranslationCacheListener: Improved cache management types✅ Testing
📝 Breaking Changes
None - All changes are internal improvements that don't affect the public API.
🔗 Related Issues
Improves code quality and maintainability through modern PHP features.
📚 Documentation