REF,WIP: Support pydantic v2 with pydantic.v1#14
Open
westurner wants to merge 1 commit intolexiq-legal:mainfrom
Open
REF,WIP: Support pydantic v2 with pydantic.v1#14westurner wants to merge 1 commit intolexiq-legal:mainfrom
westurner wants to merge 1 commit intolexiq-legal:mainfrom
Conversation
|
Why is this not accepted yet? |
Author
|
Are there tests/ or a .github/workflows/build.yml to be sure this doesn't
break other code?
- [ ] tests pass
- [ ] remove the WIP workinprogress codelabel from the issue subject
…On Wed, Mar 5, 2025, 6:33 AM George Tantiras ***@***.***> wrote:
Why is this not accepted yet?
—
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMNS4OSVC4Y6R5KZSUSYL2S3OIZAVCNFSM6AAAAABQIREQUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBQGY3DSMZUHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: raratiru]*raratiru* left a comment
(lexiq-legal/pydantic_schemaorg#14)
<#14 (comment)>
Why is this not accepted yet?
—
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMNS4OSVC4Y6R5KZSUSYL2S3OIZAVCNFSM6AAAAABQIREQUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBQGY3DSMZUHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Author
|
A Test Case which must validate RDFS properties from multiple rdfs:Class
with rdf:subClassOf relations:
- C: Thing > CreativeWork > ScholarlyArticle > MedicalScholarlyArticle
- P: publicationType d: MedicalScholarlyArticle
- P: name d: Thing
- P: wordCount d: Article
- P: authors r: (Organization, Person)
- P: funder r: (Organization, Person)
- P: funding r: Grant
- [ ] TST: Validate a deeply-nested schema.org class
- [ ] BLD,TST: run pytest in GitHub actions in a container with pydantic v2
…On Wed, Mar 5, 2025, 8:35 PM Wes Turner ***@***.***> wrote:
Are there tests/ or a .github/workflows/build.yml to be sure this doesn't
break other code?
- [ ] tests pass
- [ ] remove the WIP workinprogress codelabel from the issue subject
On Wed, Mar 5, 2025, 6:33 AM George Tantiras ***@***.***>
wrote:
> Why is this not accepted yet?
>
> —
> Reply to this email directly, view it on GitHub
> <#14 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAAMNS4OSVC4Y6R5KZSUSYL2S3OIZAVCNFSM6AAAAABQIREQUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBQGY3DSMZUHE>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
> [image: raratiru]*raratiru* left a comment
> (lexiq-legal/pydantic_schemaorg#14)
> <#14 (comment)>
>
> Why is this not accepted yet?
>
> —
> Reply to this email directly, view it on GitHub
> <#14 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAAMNS4OSVC4Y6R5KZSUSYL2S3OIZAVCNFSM6AAAAABQIREQUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBQGY3DSMZUHE>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
|
I appreciate the effort to update this. This commit is currently causing an error with the most recent version of Pydantic. Wouldn't take much to fix, but just wanted to make everyone aware. pydantic.errors.PydanticImportError: |
Author
|
Which file does that exception occur from?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seeAlso: