Skip to content

Token double free as error #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Token double free as error #300

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
805d472
Turn double-freeing of tokens into a critical error
erlingrj Nov 3, 2023
32a42e4
Merge remote-tracking branch 'origin/main' into token-double-free-as-…
erlingrj Nov 3, 2023
0120c00
Merge branch 'main' into token-double-free-as-error
edwardalee Jun 17, 2025
3684e7f
Merge branch 'main' into token-double-free-as-error
edwardalee Jul 8, 2025
a327ac9
Merge branch 'main' into token-double-free-as-error
edwardalee Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions core/lf_token.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ token_freed _lf_free_token(lf_token_t* token) {
// Recycle instead of freeing.
LF_PRINT_DEBUG("_lf_free_token: Putting token on the recycling bin: %p", (void*)token);
if (!hashset_add(_lf_token_recycling_bin, token)) {
lf_print_warning("Putting token %p on the recycling bin, but it is already there!", (void*)token);
lf_print_error_and_exit("Putting token %p on the recycling bin, but it is already there!", (void*)token);
}
} else {
// Recycling bin is full.
Expand Down Expand Up @@ -360,8 +360,7 @@ token_freed _lf_done_using(lf_token_t* token) {
}
LF_PRINT_DEBUG("_lf_done_using: token = %p, ref_count = %zu.", (void*)token, token->ref_count);
if (token->ref_count == 0) {
lf_print_warning("Token being freed that has already been freed: %p", (void*)token);
return NOT_FREED;
lf_print_error_and_exit("Token being freed that has already been freed: %p", (void*)token);
}
token->ref_count--;
return _lf_free_token(token);
Expand Down
Loading