Tighten mTLS port probe to suppress false Envoy warnings on TLS-only ports#196
Merged
ramkri123 merged 1 commit intolfedgeai:mainfrom Feb 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The pre-flight port probe introduced in #195 produced a spurious warning when Envoy was healthy. This corrects the probe logic to accurately distinguish between a non-TLS service claiming the port and expected TLS rejection.
Root Cause
curl -w '%{http_code}'always writes the HTTP status code to stdout regardless of exit status. The trailing|| echo '000'fallback was doubling the output to000000, which failed the!= "000"guard and triggered the warning even when Envoy was operating correctly in mTLS-only mode.Change
|| echo '000'fallback — unnecessary given curl's-wbehavior!= "000") with a regex (^[1-9][0-9]{2}$) that only warns on a real HTTP status code (100–999)000(no HTTP response at TLS layer), which now correctly passes the probe silentlyBehavior