fix: prevent LangChain connection errors from garbage collection#73
Merged
fix: prevent LangChain connection errors from garbage collection#73
Conversation
When to_langchain() was called, Esperanto shared its httpx clients with LangChain. When the Esperanto model went out of scope and was garbage collected, __del__ closed those shared clients, causing LangChain to get "Connection error" when trying to make requests. This fix adds _create_langchain_http_clients() method that creates fresh httpx clients with the same configuration (timeout, SSL, proxy). This gives LangChain ownership of its own clients that won't be affected when the Esperanto model is garbage collected. Affected providers: openai, groq, perplexity, openai_compatible, azure Fixes: lfnovo/open-notebook#460
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_create_langchain_http_clients()method to create fresh httpx clients for LangChainProblem
When
to_langchain()was called, Esperanto shared its httpx clients with LangChain. When the Esperanto model went out of scope and was garbage collected:HttpConnectionMixin.__del__()was calledSolution
Instead of sharing Esperanto's HTTP clients with LangChain, we now create fresh httpx clients with the same configuration (timeout, SSL, proxy). This gives LangChain ownership of its own clients that won't be affected when the Esperanto model is garbage collected.
Files Changed
src/esperanto/utils/connect.py- Added_create_langchain_http_clients()methodsrc/esperanto/providers/llm/openai.py- Use new methodsrc/esperanto/providers/llm/groq.py- Use new methodsrc/esperanto/providers/llm/perplexity.py- Use new methodsrc/esperanto/providers/llm/openai_compatible.py- Use new methodsrc/esperanto/providers/llm/azure.py- Use new methodTest plan
Fixes: lfnovo/open-notebook#460