feat: use standard proxy environment variables#75
Merged
Conversation
BREAKING CHANGE: Remove ESPERANTO_PROXY and config={"proxy": ...} support
Simplify proxy configuration by delegating entirely to httpx, which
natively supports HTTP_PROXY, HTTPS_PROXY, and NO_PROXY environment
variables.
Changes:
- Remove _get_proxy() method from HttpConnectionMixin
- Simplify _create_http_clients() and _create_langchain_http_clients()
- Remove tests/test_proxy_configuration.py (no longer needed)
- Update documentation to reflect standard env vars
Migration:
- Replace ESPERANTO_PROXY with HTTP_PROXY and/or HTTPS_PROXY
- Remove config={"proxy": ...} usage, use env vars instead
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
leejangthegreat
added a commit
to leejangthegreat/esperanto
that referenced
this pull request
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HTTP_PROXY,HTTPS_PROXY, andNO_PROXYenvironment variablesESPERANTO_PROXYvariable andconfig={"proxy": ...}parameterBreaking Changes
ESPERANTO_PROXYenvironment variable no longer supportedconfig={"proxy": "..."}parameter no longer supportedMigration
Replace:
With:
Changes
_get_proxy()method fromHttpConnectionMixin_create_http_clients()and_create_langchain_http_clients()tests/test_proxy_configuration.py(no longer needed - no proxy logic in Esperanto)Test plan
NO_PROXYworks correctly