feat: Vertex AI credentials support and LangChain migration#79
Merged
Conversation
There was a problem hiding this comment.
1 issue found across 7 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="src/esperanto/providers/llm/vertex.py">
<violation number="1" location="src/esperanto/providers/llm/vertex.py:103">
P1: When `credentials_file` is explicitly provided, loading failures (missing `google-auth` or invalid file) should raise an error instead of silently falling back to other methods. This prevents using incorrect identities (e.g., personal gcloud credentials) when the intended service account fails to load.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
- Add credentials_file parameter with priority chain: explicit file, GOOGLE_APPLICATION_CREDENTIALS env var, ADC, gcloud CLI fallback - Migrate to_langchain() from deprecated ChatVertexAI to ChatGoogleGenerativeAI (langchain-google-genai) - Remove langchain-google-vertexai dependency - Add comprehensive tests for credential loading and LangChain migration - Bump version to 2.19.0
5cb4cc8 to
e393d1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
credentials_fileparameter to Vertex AI provider with full credentials priority chain (explicit file →GOOGLE_APPLICATION_CREDENTIALS→ ADC → gcloud CLI fallback)to_langchain()from deprecatedChatVertexAI(langchain-google-vertexai) toChatGoogleGenerativeAI(langchain-google-genai)langchain-google-vertexaidev dependencyTest plan
langchain-google-vertexaiin source codeuv sync --all-extrassucceeds with updated lock file