Skip to content

Several MinGW compilation issue fixes, and other improvements.#127

Open
mcourteaux wants to merge 6 commits intolfreist:mainfrom
mcourteaux:main
Open

Several MinGW compilation issue fixes, and other improvements.#127
mcourteaux wants to merge 6 commits intolfreist:mainfrom
mcourteaux:main

Conversation

@mcourteaux
Copy link

@mcourteaux mcourteaux commented Jul 31, 2025

Windows has a case-insensitive file system, but it seems the header files actually have a small-case spelling.

feat(macos): Implement MTLDevice detection.
feat(linux): Get GPU driver version without OpenCL.
fix(build): Windows headers are small letter.
fix(build): Some Windows API use wchar_t.
fix(build): Add include for <sstream>

feat(linux): Get GPU driver version without OpenCL.
fix(build): Windows headers are small letter.
fix(build): Some Windows API use wchar_t.
fix(build): Add include for <sstream>
@mcourteaux mcourteaux changed the title Several MinGW compilation issue fixes. Several MinGW compilation issue fixes, and other improvements. Jul 31, 2025
@lfreist
Copy link
Owner

lfreist commented Aug 4, 2025

Hey, thank you for committing, could you please elaborate why macOS is failing and fix the code formatting?

Thank you!

@mcourteaux
Copy link
Author

I don't know why it failed. Internet people seem to suggest that the file should be renamed to end in .mm. However, I tried adding #import <Foundation/Foundation.h> first.

@mcourteaux
Copy link
Author

@lfreist Okay, the .mm extension worked. However, the MainBord deprecation is not something I touched. However, I pushed a fix in accordance with apple documentation:

https://developer.apple.com/documentation/iokit/kiomasterportdefault/ (See Discussion section)

@mcourteaux
Copy link
Author

mcourteaux commented Aug 7, 2025

Omg. the deprecation note was a lie. Replaced NULL with 0 now.

@lfreist
Copy link
Owner

lfreist commented Aug 7, 2025

I hope this PR won't exceed my free tier GitHub action limit, haha. Joke, thanks for committing!

@mcourteaux
Copy link
Author

mcourteaux commented Aug 7, 2025

Okay, maybe I'll grab my macbook, and try for myself to compile this on the actual system. :P This is getting ridiculous. Thanks for dealing with this nonsense 😋

@lfreist
Copy link
Owner

lfreist commented Aug 7, 2025

No problem. I am happy you care about the MacOS support since it's part of hwinfos goal and I don't have a Mac to develop...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants