make compile with mingw-w64#131
Merged
lfreist merged 1 commit intolfreist:mainfrom Nov 14, 2025
oltolm:mingw-w64-upstream
Merged
make compile with mingw-w64#131lfreist merged 1 commit intolfreist:mainfrom oltolm:mingw-w64-upstream
lfreist merged 1 commit intolfreist:mainfrom
oltolm:mingw-w64-upstream
Conversation
oltolm
commented
Nov 18, 2025
| res &= CoInitializeEx(nullptr, COINIT_APARTMENTTHREADED); | ||
| res &= CoCreateInstance(CLSID_WbemLocator, nullptr, CLSCTX_INPROC_SERVER, IID_IWbemLocator, (LPVOID*)&locator); | ||
| if (locator) { | ||
| res &= locator->ConnectServer(_bstr_t("ROOT\\CIMV2"), nullptr, nullptr, nullptr, 0, nullptr, nullptr, &service); |
Contributor
Author
There was a problem hiding this comment.
It seems that was wrong and mingw-w64 actually does support _bstr_t. This change was unnecessary.
I mean the change from _bstr_t to bstr_t. The change from "ROOT\\CIMV2" to L"ROOT\\CIMV2" was necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code was not compiling with mingw-w64 because it does not support
_bstr_t.