Skip to content

Adapt to new pango bindings #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reinerh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adapt to new pango bindings #342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tests/pango.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ function pango.glyphstring()
local offset = items[i].offset
local length = items[i].length
local analysis = items[i].analysis
local pgs = Pango.GlyphString()
Pango.shape(string.sub(s,1+offset), length, analysis, pgs)
pgs = Pango.shape(string.sub(s,1+offset), length, analysis)
Copy link

@ildar ildar Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the reason of removing local here?

-- Pull out individual glyphs with pgs.glyphs
local glyphs = pgs.glyphs
check(type(glyphs) == 'table')
Expand Down
Loading