Skip to content

fix(#164): bug in diff with comps #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mathtimm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(#164): bug in diff with comps #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion prose/fluxes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ def diff(self, comps: np.ndarray = None):
differential :code:`Fluxes`
"""
if comps is not None:
weights = np.zeros(self.fluxes[0:2])
weights = np.zeros(self.fluxes.shape[0:-1])
weights[:, comps] = 1
else:
weights = None
Expand All @@ -335,6 +335,7 @@ def diff(self, comps: np.ndarray = None):
diff_fluxes, diff_errors = diff(self.fluxes, weights, self.errors)
_new.fluxes = diff_fluxes
_new.errors = diff_errors
_new.aperture = _new.best_aperture_index()

return _new

Expand Down
10 changes: 9 additions & 1 deletion tests/test_fluxes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,16 @@ def test_3d():
f.error


def test_diff():
def test_auto_diff():
x = np.random.uniform(0, 10000, size=(3, 2, 10))
f = Fluxes(x)
f.target = 1
diff = f.autodiff()


def test_diff():
x = np.random.uniform(0, 10000, size=(30, 20, 10))
comps = np.repeat(np.array([[1, 12, 16]]), repeats=30, axis=0)
f = Fluxes(x)
f.target = 1
diff = f.autodiff()