Skip to content

Add option to put week numbers on either side of calendar #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
formulahunter wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add option to put week numbers on either side of calendar #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b281daf
Add week num side & default to settings tab
formulahunter Sep 12, 2022
901e5b3
Pass week num side to CalendarBase at render time
formulahunter Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export interface ISettings {

// Weekly Note settings
showWeeklyNote: boolean;
showWeeklyNoteRight: boolean;
weeklyNoteFormat: string;
weeklyNoteTemplate: string;
weeklyNoteFolder: string;
Expand All @@ -37,6 +38,7 @@ export const defaultSettings = Object.freeze({
wordsPerDot: DEFAULT_WORDS_PER_DOT,

showWeeklyNote: false,
showWeeklyNoteRight: false,
weeklyNoteFormat: "",
weeklyNoteTemplate: "",
weeklyNoteFolder: "",
Expand Down Expand Up @@ -81,6 +83,7 @@ export class CalendarSettingsTab extends PluginSettingTab {
this.addWeekStartSetting();
this.addConfirmCreateSetting();
this.addShowWeeklyNoteSetting();
this.addShowWeeklyNoteRightSetting();

if (
this.plugin.options.showWeeklyNote &&
Expand Down Expand Up @@ -174,6 +177,19 @@ export class CalendarSettingsTab extends PluginSettingTab {
});
}

addShowWeeklyNoteRightSetting(): void {
new Setting(this.containerEl)
.setName("Change week number side")
.setDesc("Enable this to show week numbers to the right of the calendar")
.addToggle((toggle) => {
toggle.setValue(this.plugin.options.showWeeklyNoteRight);
toggle.onChange(async (value) => {
this.plugin.writeOptions(() => ({ showWeeklyNoteRight: value }));
this.display(); // show/hide weekly settings
});
});
}

addWeeklyNoteFormatSetting(): void {
new Setting(this.containerEl)
.setName("Weekly note format")
Expand Down
1 change: 1 addition & 0 deletions src/testUtils/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export function getDefaultSettings(
shouldConfirmBeforeCreate: false,
wordsPerDot: 50,
showWeeklyNote: false,
showWeeklyNoteRight: false,
weeklyNoteFolder: "",
weeklyNoteFormat: "",
weeklyNoteTemplate: "",
Expand Down
1 change: 1 addition & 0 deletions src/ui/Calendar.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,5 @@
localeData={today.localeData()}
selectedId={$activeFile}
showWeekNums={$settings.showWeeklyNote}
showWeekNumsRight={$settings.showWeeklyNoteRight}
/>