Skip to content

fixed weeknumber displayed on calendar to ISO Week number#18

Open
muejam09 wants to merge 1 commit intoliamcain:masterfrom
muejam09:master
Open

fixed weeknumber displayed on calendar to ISO Week number#18
muejam09 wants to merge 1 commit intoliamcain:masterfrom
muejam09:master

Conversation

@muejam09
Copy link

@muejam09 muejam09 commented Oct 3, 2022

I would recommend using the ISO standard for numbering the weeks of a year. Because for example, for 2022 the plugin shows the wron weeknumber

@usagizmo
Copy link

Since there are multiple calendar types, I feel that date.isoWeek() should not simply be used.

  • US calendar begins on Sunday (+ January 1 as the first week) - date.week()
  • EU calendar begins on Monday (+ January 4 as the first week) - date.isoWeek()

like: usagizmo#1

@muejam09
Copy link
Author

I did not think about that... But wouldn't a option in the settings be the right choice then?
I just saw you tried it with, #19? You stopped working on it because file creation when clicking on the weeknumber did not work?

@usagizmo
Copy link

You stopped working on it because file creation when clicking on the weeknumber did not work?

That is one thing, but even if I could fix it, it seems unlikely that the PR would be merged (due to the multiple repositories involved), so I have given up on creating a PR.

@muejam09
Copy link
Author

Okay... i was confused about this too. Do I understand it correctly, that multiple PR in multiple repositories are needed to make it work correctly?

@usagizmo
Copy link

Yes, it is a dependency and requires updating multiple repositories...!

@muejam09
Copy link
Author

muejam09 commented Jan 2, 2023

Hi! I think I know why opening the files did not work.. I think it was because of the gggg Setting for the weekly format. It does now work in the new Year. If you switch it to GGGG it already worked in the old year. Atleast thats how i understand it so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants