Fix weekday header mismatch when weekStart is not Sunday#23
Open
JacobBrooke95 wants to merge 1 commit intoliamcain:masterfrom
Open
Fix weekday header mismatch when weekStart is not Sunday#23JacobBrooke95 wants to merge 1 commit intoliamcain:masterfrom
JacobBrooke95 wants to merge 1 commit intoliamcain:masterfrom
Conversation
When weekStart is set to something other than Sunday (e.g., Monday), moment.weekdaysShort(true) doesn't reliably return days starting from the locale's first day of week. This causes the day labels in the header to not match the actual day positions in the calendar grid. This fix manually rotates the weekdays array based on the locale's dow (day of week) setting. Fixes liamcain/obsidian-calendar-plugin#346 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
weekStartis set to something other than Sunday (e.g., Monday),moment.weekdaysShort(true)doesn't reliably return days starting from the locale's first day of week. This causes the day labels in the calendar header to not match the actual day positions in the calendar grid.For example, with
weekStart: "monday", the calendar would display "Sun" in the first column but show Monday's dates underneath it.The Fix
Instead of relying on
moment.weekdaysShort(true), this fix manually rotates the weekdays array based on the locale'sdow(day of week) setting:Related Issue
Fixes liamcain/obsidian-calendar-plugin#346
Testing
Tested locally by modifying the compiled
main.jsin the calendar plugin with this fix. Confirmed that withweekStart: "monday":🤖 Generated with Claude Code