Fix GhostPointNeighbors::mesh_reinit() #4363
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were getting away with this being broken in cases where a partitioning didn't leave any processors with no elements, or in cases where we didn't have any disjoint boundaries, but in distributed-mesh sweeps with disjoint boundaries we were losing sync as the processors with elements waited for the processor(s) without to help them build a master point locator tree. Refs libMesh#4283
|
Job Test ARM mac on 9e80ba9 : invalidated by @roystgnr |
Member
Author
|
That ARM Mac fetch failure was unrelated but it's also a short test so I'll re-run before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were getting away with this being broken in cases where a partitioning didn't leave any processors with no elements, or in cases where we didn't have any disjoint boundaries, but in distributed-mesh sweeps with disjoint boundaries we were losing sync as the processors with elements waited for the processor(s) without to help them build a master point locator tree.
Refs #4283
This fixes the failure in idaholab/moose#32192 that @hugary1995 showed me how to reproduce.