Skip to content

Fix get_locator_span lower limit. #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 1 commit into from
Jun 4, 2025
Merged

Fix get_locator_span lower limit. #652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions include/bitcoin/database/impl/query/network.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ CLASS::span CLASS::get_locator_span(const hashes& locator,
const hash_digest& stop, size_t limit) const NOEXCEPT
{
using namespace system;
span out{};

// Start at fork point, stop at given header (both excluded).
const auto start = add1(get_fork(locator));
Expand All @@ -94,9 +93,12 @@ CLASS::span CLASS::get_locator_span(const hashes& locator,
const auto top1 = ceilinged_add(get_top_confirmed(), one);
const auto end = std::min(ceilinged_add(start, allowed), top1);

// Convert negative range to empty.
out.end = std::max(start, end);
return out;
// max converts negative range to empty.
return
{
start,
std::max(start, end)
};
}

// protected
Expand Down
Loading