Apply transactor to prevout reads, add not_coalesced ec.

include/bitcoin/database/error.hpp

@@ -85,6 +85,7 @@ enum error_t : uint8_t
     copy_directory,
 
     /// store
+    not_coalesced,
     missing_snapshot,
     unloaded_file,
 

include/bitcoin/database/impl/query/consensus.ipp

@@ -221,7 +221,14 @@ error::error_t CLASS::unspendable(uint32_t sequence, bool coinbase,
 TEMPLATE
 bool CLASS::is_prevouts_cached(const header_link& link) const NOEXCEPT
 {
-    return store_.prevout.exists(to_prevout(link));
+    const auto prevout = to_prevout(link);
+
+    // Transactor required for prevout read because of pruning.
+    // ========================================================================
+    const auto scope = store_.get_transactor();
+
+    return store_.prevout.exists(prevout);
+    // ========================================================================
 }
 
 TEMPLATE
@@ -235,8 +242,18 @@ code CLASS::populate_prevouts(point_sets& sets, size_t points,
     // An empty block will fail here as no prevout element is populated.
     table::prevout::slab_get cache{};
     cache.spends.resize(points);
-    if (!store_.prevout.at(to_prevout(link), cache))
-        return error::integrity5;
+    const auto prevout = to_prevout(link);
+
+    // Transactor required for prevout read because of pruning.
+    // ========================================================================
+    {
+        const auto scope = store_.get_transactor();
+
+        if (!store_.prevout.at(prevout, cache))
+            return error::integrity5;
+
+    }
+    // ========================================================================
 
     // Is any duplicated point in the block confirmed (generally empty).
     for (const auto& spender: cache.conflicts)
@@ -494,12 +511,14 @@ bool CLASS::set_prevouts(const header_link& link, const block& block) NOEXCEPT
     if (!get_doubles(doubles, block))
         return false;
 
+    const auto prevout = to_prevout(link);
+
     // ========================================================================
     const auto scope = store_.get_transactor();
 
     // Clean single allocation failure (e.g. disk full).
     const table::prevout::slab_put_ref prevouts{ {}, doubles, block };
-    return store_.prevout.put(to_prevout(link), prevouts);
+    return store_.prevout.put(prevout, prevouts);
     // ========================================================================
 }
 

include/bitcoin/database/impl/store.ipp

@@ -421,6 +421,8 @@ code CLASS::open(const event_handler& handler) NOEXCEPT
 TEMPLATE
 code CLASS::prune(const event_handler& handler) NOEXCEPT
 {
+    // Transactor lock generally only covers writes, but in this case prevout
+    // reads must also be guarded since the body shrinks and head is cleared.
     while (!transactor_mutex_.try_lock_for(std::chrono::seconds(1)))
     {
         handler(event_t::wait_lock, table_t::store);
@@ -467,6 +469,10 @@ code CLASS::prune(const event_handler& handler) NOEXCEPT
         // map body, making table usable again.
         load(ec, prevout_body_, table_t::prevout_body);
     }
+    else
+    {
+        ec = error::not_coalesced;
+    }
 
     transactor_mutex_.unlock();
     return ec;

src/error.cpp

@@ -75,8 +75,10 @@ DEFINE_ERROR_T_MESSAGE_MAP(error)
     { missing_directory, "missing directory failure" },
     { clear_directory, "clear directory failure" },
     { rename_directory, "rename directory failure" },
+    { copy_directory, "copy directory failure" },
 
     // store
+    { not_coalesced, "not coalesced" },
     { missing_snapshot, "missing snapshot" },
     { unloaded_file, "file not loaded" },
 

test/error.cpp

@@ -293,6 +293,24 @@ BOOST_AUTO_TEST_CASE(error_t__code__rename_directory__true_exected_message)
     BOOST_REQUIRE_EQUAL(ec.message(), "rename directory failure");
 }
 
+BOOST_AUTO_TEST_CASE(error_t__code__copy_directory__true_exected_message)
+{
+    constexpr auto value = error::copy_directory;
+    const auto ec = code(value);
+    BOOST_REQUIRE(ec);
+    BOOST_REQUIRE(ec == value);
+    BOOST_REQUIRE_EQUAL(ec.message(), "copy directory failure");
+}
+
+BOOST_AUTO_TEST_CASE(error_t__code__not_coalesced__true_exected_message)
+{
+    constexpr auto value = error::not_coalesced;
+    const auto ec = code(value);
+    BOOST_REQUIRE(ec);
+    BOOST_REQUIRE(ec == value);
+    BOOST_REQUIRE_EQUAL(ec.message(), "not coalesced");
+}
+
 BOOST_AUTO_TEST_CASE(error_t__code__missing_snapshot__true_exected_message)
 {
     constexpr auto value = error::missing_snapshot;