Skip to content

Add MADV_WILLNEED to macos madvise calls. #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 1 commit into from
Oct 12, 2025
Merged

Add MADV_WILLNEED to macos madvise calls. #676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/memory/map.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,8 @@ bool map::finalize_(size_t size) NOEXCEPT

// Use 1GB chunks to avoid large-length issues.
constexpr auto chunk = power2(30u);
const auto advice = random_ ? MADV_RANDOM : MADV_SEQUENTIAL;
const auto advice = (random_ ? MADV_RANDOM : MADV_SEQUENTIAL) |
MADV_WILLNEED;

for (auto offset = zero; offset < align; offset += chunk)
{
Expand Down
Loading