Skip to content

Conversation

@pmienk
Copy link
Member

@pmienk pmienk commented Dec 11, 2024

No description provided.

@coveralls
Copy link

Coverage Status

coverage: 92.025%. remained the same
when pulling fa1de6a on pmienk:master
into 4ba7a53 on libbitcoin:master.

Copy link
Contributor

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested locally

one micro nit is that in the CI, --build-secp256k1 has two white spaces after the prior option. idk and couldn't figure out why

@pmienk pmienk merged commit 9af3dcc into libbitcoin:master Dec 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants