Skip to content

Remove obsolete workaround for lack of std::views::reverse. #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 1 commit into from
Jan 29, 2025
Merged

Remove obsolete workaround for lack of std::views::reverse. #722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions include/bitcoin/node/impl/chasers/chaser_organize.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#define LIBBITCOIN_NODE_CHASERS_CHASER_ORGANIZE_IPP

#include <algorithm>
#include <ranges>
#include <bitcoin/database.hpp>
#include <bitcoin/network.hpp>
#include <bitcoin/node/chasers/chaser.hpp>
Expand Down Expand Up @@ -260,7 +261,7 @@ void CLASS::do_organize(typename Block::cptr block,
notify(error::success, chase::regressed, branch_point);

// Push stored strong headers to candidate chain.
for (const auto& link: views_reverse(store_branch))
for (const auto& link: std::views::reverse(store_branch))
{
if ((is_under_milestone(index) && !query.set_strong(link)) ||
!query.push_candidate(link))
Expand All @@ -274,7 +275,7 @@ void CLASS::do_organize(typename Block::cptr block,
}

// Store strong tree headers and push to candidate chain.
for (const auto& key: views_reverse(tree_branch))
for (const auto& key: std::views::reverse(tree_branch))
{
if ((ec = push_block(key)))
{
Expand Down
3 changes: 2 additions & 1 deletion src/chasers/chaser_confirm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#include <bitcoin/node/chasers/chaser_confirm.hpp>

#include <functional>
#include <ranges>
#include <utility>
#include <bitcoin/database.hpp>
#include <bitcoin/network.hpp>
Expand Down Expand Up @@ -561,7 +562,7 @@ bool chaser_confirm::roll_back(const header_links& popped, size_t fork_point,
if (!set_reorganized(query.to_confirmed(height), height))
return false;

for (const auto& fk: views_reverse(popped))
for (const auto& fk: std::views::reverse(popped))
if (!reset_organized(fk, ++fork_point))
return false;

Expand Down
Loading