Skip to content

Disable set_confirmable(). #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 1 commit into from
Feb 8, 2025
Merged

Disable set_confirmable(). #731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/chasers/chaser_confirm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,11 +231,13 @@ void chaser_confirm::do_bump(height_t) NOEXCEPT
return;
}

if (!query.set_block_confirmable(link))
{
fault(error::confirm5);
return;
}
// This is not necessary and may overflow the table link. Faster to
// never do it and redo a tiny number of blocks in case of reorg.
////if (!query.set_block_confirmable(link))
////{
//// fault(error::confirm5);
//// return;
////}

// Set after if using prevout table.
if (prevout_ && !query.set_strong(link))
Expand Down
Loading