Implement path_to_request, full tests.

Makefile.am

@@ -70,6 +70,7 @@ src_libbitcoin_node_la_SOURCES = \
     src/protocols/protocol_performer.cpp \
     src/protocols/protocol_transaction_in_106.cpp \
     src/protocols/protocol_transaction_out_106.cpp \
+    src/rest/rest.cpp \
     src/sessions/session.cpp \
     src/sessions/session_inbound.cpp \
     src/sessions/session_manual.cpp \
@@ -106,6 +107,7 @@ test_libbitcoin_node_test_SOURCES = \
     test/chasers/chaser_transaction.cpp \
     test/chasers/chaser_validate.cpp \
     test/protocols/protocol.cpp \
+    test/rest/rest.cpp \
     test/sessions/session.cpp
 
 endif WITH_TESTS
@@ -225,6 +227,10 @@ include_bitcoin_node_protocols_HEADERS = \
     include/bitcoin/node/protocols/protocol_ws.hpp \
     include/bitcoin/node/protocols/protocols.hpp
 
+include_bitcoin_node_restdir = ${includedir}/bitcoin/node/rest
+include_bitcoin_node_rest_HEADERS = \
+    include/bitcoin/node/rest/rest.hpp
+
 include_bitcoin_node_sessionsdir = ${includedir}/bitcoin/node/sessions
 include_bitcoin_node_sessions_HEADERS = \
     include/bitcoin/node/sessions/session.hpp \

builds/cmake/CMakeLists.txt

@@ -282,6 +282,7 @@ add_library( ${CANONICAL_LIB_NAME}
     "../../src/protocols/protocol_performer.cpp"
     "../../src/protocols/protocol_transaction_in_106.cpp"
     "../../src/protocols/protocol_transaction_out_106.cpp"
+    "../../src/rest/rest.cpp"
     "../../src/sessions/session.cpp"
     "../../src/sessions/session_inbound.cpp"
     "../../src/sessions/session_manual.cpp"
@@ -348,6 +349,7 @@ if (with-tests)
         "../../test/chasers/chaser_transaction.cpp"
         "../../test/chasers/chaser_validate.cpp"
         "../../test/protocols/protocol.cpp"
+        "../../test/rest/rest.cpp"
         "../../test/sessions/session.cpp" )
 
     add_test( NAME libbitcoin-node-test COMMAND libbitcoin-node-test

builds/msvc/vs2022/libbitcoin-node-test/libbitcoin-node-test.vcxproj

@@ -135,6 +135,7 @@
     <ClCompile Include="..\..\..\..\test\main.cpp" />
     <ClCompile Include="..\..\..\..\test\node.cpp" />
     <ClCompile Include="..\..\..\..\test\protocols\protocol.cpp" />
+    <ClCompile Include="..\..\..\..\test\rest\rest.cpp" />
     <ClCompile Include="..\..\..\..\test\sessions\session.cpp" />
     <ClCompile Include="..\..\..\..\test\settings.cpp" />
     <ClCompile Include="..\..\..\..\test\test.cpp" />

builds/msvc/vs2022/libbitcoin-node-test/libbitcoin-node-test.vcxproj.filters

@@ -16,9 +16,12 @@
     <Filter Include="src\protocols">
       <UniqueIdentifier>{4BD50864-D3BC-4F64-0000-000000000002}</UniqueIdentifier>
     </Filter>
-    <Filter Include="src\sessions">
+    <Filter Include="src\rest">
       <UniqueIdentifier>{4BD50864-D3BC-4F64-0000-000000000003}</UniqueIdentifier>
     </Filter>
+    <Filter Include="src\sessions">
+      <UniqueIdentifier>{4BD50864-D3BC-4F64-0000-000000000004}</UniqueIdentifier>
+    </Filter>
   </ItemGroup>
   <ItemGroup>
     <ClCompile Include="..\..\..\..\test\block_arena.cpp">
@@ -72,6 +75,9 @@
     <ClCompile Include="..\..\..\..\test\protocols\protocol.cpp">
       <Filter>src\protocols</Filter>
     </ClCompile>
+    <ClCompile Include="..\..\..\..\test\rest\rest.cpp">
+      <Filter>src\rest</Filter>
+    </ClCompile>
     <ClCompile Include="..\..\..\..\test\sessions\session.cpp">
       <Filter>src\sessions</Filter>
     </ClCompile>

builds/msvc/vs2022/libbitcoin-node/libbitcoin-node.vcxproj

@@ -155,6 +155,7 @@
     <ClCompile Include="..\..\..\..\src\protocols\protocol_performer.cpp" />
     <ClCompile Include="..\..\..\..\src\protocols\protocol_transaction_in_106.cpp" />
     <ClCompile Include="..\..\..\..\src\protocols\protocol_transaction_out_106.cpp" />
+    <ClCompile Include="..\..\..\..\src\rest\rest.cpp" />
     <ClCompile Include="..\..\..\..\src\sessions\session.cpp" />
     <ClCompile Include="..\..\..\..\src\sessions\session_inbound.cpp" />
     <ClCompile Include="..\..\..\..\src\sessions\session_manual.cpp" />
@@ -217,6 +218,7 @@
     <ClInclude Include="..\..\..\..\include\bitcoin\node\protocols\protocol_web.hpp" />
     <ClInclude Include="..\..\..\..\include\bitcoin\node\protocols\protocol_ws.hpp" />
     <ClInclude Include="..\..\..\..\include\bitcoin\node\protocols\protocols.hpp" />
+    <ClInclude Include="..\..\..\..\include\bitcoin\node\rest\rest.hpp" />
     <ClInclude Include="..\..\..\..\include\bitcoin\node\sessions\session.hpp" />
     <ClInclude Include="..\..\..\..\include\bitcoin\node\sessions\session_inbound.hpp" />
     <ClInclude Include="..\..\..\..\include\bitcoin\node\sessions\session_manual.hpp" />

builds/msvc/vs2022/libbitcoin-node/libbitcoin-node.vcxproj.filters

@@ -8,34 +8,37 @@
 <Project DefaultTargets="Build" ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <ItemGroup>
     <Filter Include="include">
-      <UniqueIdentifier>{5FFB5F52-0772-4404-0000-000000000005}</UniqueIdentifier>
+      <UniqueIdentifier>{5FFB5F52-0772-4404-0000-000000000006}</UniqueIdentifier>
     </Filter>
     <Filter Include="include\bitcoin">
-      <UniqueIdentifier>{5FFB5F52-0772-4404-0000-000000000006}</UniqueIdentifier>
+      <UniqueIdentifier>{5FFB5F52-0772-4404-0000-000000000007}</UniqueIdentifier>
     </Filter>
     <Filter Include="include\bitcoin\node">
-      <UniqueIdentifier>{5FFB5F52-0772-4404-0000-000000000007}</UniqueIdentifier>
+      <UniqueIdentifier>{5FFB5F52-0772-4404-0000-000000000008}</UniqueIdentifier>
     </Filter>
     <Filter Include="include\bitcoin\node\channels">
-      <UniqueIdentifier>{5FFB5F52-0772-4404-0000-000000000008}</UniqueIdentifier>
+      <UniqueIdentifier>{5FFB5F52-0772-4404-0000-000000000009}</UniqueIdentifier>
     </Filter>
     <Filter Include="include\bitcoin\node\chasers">
-      <UniqueIdentifier>{5FFB5F52-0772-4404-0000-000000000009}</UniqueIdentifier>
+      <UniqueIdentifier>{5FFB5F52-0772-4404-0000-00000000000A}</UniqueIdentifier>
     </Filter>
     <Filter Include="include\bitcoin\node\impl">
-      <UniqueIdentifier>{5FFB5F52-0772-4404-0000-00000000000A}</UniqueIdentifier>
+      <UniqueIdentifier>{5FFB5F52-0772-4404-0000-00000000000B}</UniqueIdentifier>
     </Filter>
     <Filter Include="include\bitcoin\node\impl\chasers">
-      <UniqueIdentifier>{5FFB5F52-0772-4404-0000-00000000000D}</UniqueIdentifier>
+      <UniqueIdentifier>{5FFB5F52-0772-4404-0000-00000000000F}</UniqueIdentifier>
     </Filter>
     <Filter Include="include\bitcoin\node\protocols">
-      <UniqueIdentifier>{5FFB5F52-0772-4404-0000-00000000000B}</UniqueIdentifier>
+      <UniqueIdentifier>{5FFB5F52-0772-4404-0000-00000000000C}</UniqueIdentifier>
+    </Filter>
+    <Filter Include="include\bitcoin\node\rest">
+      <UniqueIdentifier>{5FFB5F52-0772-4404-0000-00000000000D}</UniqueIdentifier>
     </Filter>
     <Filter Include="include\bitcoin\node\sessions">
-      <UniqueIdentifier>{5FFB5F52-0772-4404-0000-00000000000C}</UniqueIdentifier>
+      <UniqueIdentifier>{5FFB5F52-0772-4404-0000-00000000000E}</UniqueIdentifier>
     </Filter>
     <Filter Include="resource">
-      <UniqueIdentifier>{5FFB5F52-0772-4404-0000-00000000000E}</UniqueIdentifier>
+      <UniqueIdentifier>{5FFB5F52-0772-4404-0000-000000000001}</UniqueIdentifier>
     </Filter>
     <Filter Include="src">
       <UniqueIdentifier>{5FFB5F52-0772-4404-0000-000000000000}</UniqueIdentifier>
@@ -49,9 +52,12 @@
     <Filter Include="src\protocols">
       <UniqueIdentifier>{5FFB5F52-0772-4404-0000-000000000003}</UniqueIdentifier>
     </Filter>
-    <Filter Include="src\sessions">
+    <Filter Include="src\rest">
       <UniqueIdentifier>{5FFB5F52-0772-4404-0000-000000000004}</UniqueIdentifier>
     </Filter>
+    <Filter Include="src\sessions">
+      <UniqueIdentifier>{5FFB5F52-0772-4404-0000-000000000005}</UniqueIdentifier>
+    </Filter>
   </ItemGroup>
   <ItemGroup>
     <ClCompile Include="..\..\..\..\src\block_arena.cpp">
@@ -156,6 +162,9 @@
     <ClCompile Include="..\..\..\..\src\protocols\protocol_transaction_out_106.cpp">
       <Filter>src\protocols</Filter>
     </ClCompile>
+    <ClCompile Include="..\..\..\..\src\rest\rest.cpp">
+      <Filter>src\rest</Filter>
+    </ClCompile>
     <ClCompile Include="..\..\..\..\src\sessions\session.cpp">
       <Filter>src\sessions</Filter>
     </ClCompile>
@@ -338,6 +347,9 @@
     <ClInclude Include="..\..\..\..\include\bitcoin\node\protocols\protocols.hpp">
       <Filter>include\bitcoin\node\protocols</Filter>
     </ClInclude>
+    <ClInclude Include="..\..\..\..\include\bitcoin\node\rest\rest.hpp">
+      <Filter>include\bitcoin\node\rest</Filter>
+    </ClInclude>
     <ClInclude Include="..\..\..\..\include\bitcoin\node\sessions\session.hpp">
       <Filter>include\bitcoin\node\sessions</Filter>
     </ClInclude>

include/bitcoin/node.hpp

@@ -71,6 +71,7 @@
 #include <bitcoin/node/protocols/protocol_web.hpp>
 #include <bitcoin/node/protocols/protocol_ws.hpp>
 #include <bitcoin/node/protocols/protocols.hpp>
+#include <bitcoin/node/rest/rest.hpp>
 #include <bitcoin/node/sessions/session.hpp>
 #include <bitcoin/node/sessions/session_inbound.hpp>
 #include <bitcoin/node/sessions/session_manual.hpp>

include/bitcoin/node/error.hpp

@@ -98,7 +98,24 @@ enum error_t : uint8_t
     confirm10,
     confirm11,
     confirm12,
-    confirm13
+    confirm13,
+
+    /// server (url parse codes)
+    empty_path,
+    invalid_number,
+    invalid_hash,
+    missing_version,
+    missing_target,
+    invalid_target,
+    missing_hash,
+    missing_height,
+    missing_position,
+    missing_id_type,
+    invalid_id_type,
+    missing_component,
+    invalid_component,
+    invalid_subcomponent,
+    extra_segment
 };
 
 // No current need for error_code equivalence mapping.

include/bitcoin/node/full_node.hpp

@@ -206,7 +206,7 @@ class BCN_API full_node
     chaser_template chaser_template_;
     chaser_snapshot chaser_snapshot_;
     chaser_storage chaser_storage_;
-    event_subscriber event_subscriber_;
+    event_subscriber event_subscriber_{};
 };
 
 } // namespace node

include/bitcoin/node/rest/rest.hpp

@@ -0,0 +1,33 @@
+/**
+ * Copyright (c) 2011-2025 libbitcoin developers (see AUTHORS)
+ *
+ * This file is part of libbitcoin.
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+#ifndef LIBBITCOIN_NODE_REST_HPP
+#define LIBBITCOIN_NODE_REST_HPP
+
+#include <bitcoin/node/define.hpp>
+
+namespace libbitcoin {
+namespace node {
+
+BCN_API code path_to_request(network::rpc::request_t& out,
+    const std::string& path) NOEXCEPT;
+
+} // namespace network
+} // namespace libbitcoin
+
+#endif

src/error.cpp

@@ -88,7 +88,24 @@ DEFINE_ERROR_T_MESSAGE_MAP(error)
     { confirm10, "confirm10" },
     { confirm11, "confirm11" },
     { confirm12, "confirm12" },
-    { confirm13, "confirm13" }
+    { confirm13, "confirm13" },
+
+    /// server (url parse codes)
+    { empty_path, "empty_path" },
+    { invalid_number, "invalid_number" },
+    { invalid_hash, "invalid_hash" },
+    { missing_version, "missing_version" },
+    { missing_target, "missing_target" },
+    { invalid_target, "invalid_target" },
+    { missing_hash, "missing_hash" },
+    { missing_height, "missing_height" },
+    { missing_position, "missing_position" },
+    { missing_id_type, "missing_id_type" },
+    { invalid_id_type, "invalid_id_type" },
+    { missing_component, "missing_component" },
+    { invalid_component, "invalid_component" },
+    { invalid_subcomponent, "invalid_subcomponent" },
+    { extra_segment, "extra_segment" }
 };
 
 DEFINE_ERROR_T_CATEGORY(error, "node", "node code")

src/full_node.cpp

@@ -48,8 +48,7 @@ full_node::full_node(query& query, const configuration& configuration,
     chaser_transaction_(*this),
     chaser_template_(*this),
     chaser_snapshot_(*this),
-    chaser_storage_(*this),
-    event_subscriber_(strand())
+    chaser_storage_(*this)
 {
 }