Skip to content

Log store dirty/clean state at startup, comments. #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 2 commits into from
Dec 12, 2025
Merged

Log store dirty/clean state at startup, comments. #922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
845bab5
Comments on reload() effect on store dirty.
evoskuil Dec 12, 2025
685e2a5
Log store dirty/clean state at startup.
evoskuil Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion console/executor_store.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ code executor::open_store_coded(bool details)
return ec;
}

logger(BN_DATABASE_STARTED);
logger(store_.is_dirty() ? BN_DATABASE_STARTED_DIRTY : BN_DATABASE_STARTED);
return error::success;
}

Expand Down
4 changes: 3 additions & 1 deletion console/localize.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,9 @@ namespace node {
#define BN_NODE_INTERRUPT \
"Press CTRL-C to stop the node."
#define BN_DATABASE_STARTED \
"Database is started."
"Database is started (clean)."
#define BN_DATABASE_STARTED_DIRTY \
"Database is started (dirty)."
#define BN_NETWORK_STARTING \
"Please wait while network is starting..."
#define BN_NODE_START_FAIL \
Expand Down
4 changes: 4 additions & 0 deletions src/full_node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,10 @@ code full_node::reload(const store::event_handler& handler) NOEXCEPT

const auto start = logger::now();
suspend(error::store_reload);

// This will set the store's dirty flag causing increased read activity for
// set(tx/block) due to activation of duplicate detection. The store is
// is however always in a dirty state after startup with non-empty tables.
const auto ec = query_.reload([&](auto event, auto table) NOEXCEPT
{
// Suspend channels that missed previous suspend events.
Expand Down
Loading