Enable revive linter for Go code #1410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1410 +/- ##
=======================================
Coverage 95.72% 95.72%
=======================================
Files 61 61
Lines 11076 11076
=======================================
Hits 10603 10603
Misses 473 473 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d-e-s-o
approved these changes
Jan 6, 2026
Collaborator
d-e-s-o
left a comment
d-e-s-o
left a comment
There was a problem hiding this comment.
Looks good to me, thanks! Can you please rebase on main and we can get this in.
This caught missing/wrong comments and an unused param. Signed-off-by: Ivan Babrou <[email protected]>
Contributor
Author
|
So much for my conflict avoidance here! Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caught missing/wrong comments and an unused param.
This includes #1406 to avoid resolving the conflicts, so it's best to merge that fist.