Add libelf-zstd probe (Makefile.feature), then extend CI for Ubuntu 24.04 runner #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmonnet
force-pushed
the
pr/elf-zstd-static
branch
5 times, most recently
from
60fe5dd to
1f80881
Compare
Add the probe to test whether we need to link against the zstd library to use libelf in bpftool. This should ideally have been merged before commit 67f1758 ("bpftool: Link zstd lib required by libelf"), where we have the Makefile use the actual feature, but I forgot to add the probe when synchronising the repository. Elfutils commit a5b07cdf9c49 adds support for ZSTD compression, first shipped with elfutils 0.189. Distros now have it; for example, Ubuntu 22.04 ships version 0.186 (or 0.188 in backports), but Ubuntu 24.04 has 0.189 or 0.190 depending on the arch. While we edit the Makefile.feature, make sure to send the output to /dev/null (rather than '-', sometimes interpreted as a file name) for all probes for which we don't need grepping from the output. Link: https://sourceware.org/git/?p=elfutils.git;a=commit;h=a5b07cdf9c491fb7a4a16598c482c68b718f59b9 Signed-off-by: Quentin Monnet <[email protected]>
Add a matrix job to run the build on Ubuntu 24.04 runners. This requires cheating to make the static build with libbfd-based disassembler work: we manually pass all required libraries via the $(LIBS) variable, given that the Makefile.feature is not able to tell about -lzstd or -lsframe for libbfd yet. Signed-off-by: Quentin Monnet <[email protected]>
qmonnet
force-pushed
the
pr/elf-zstd-static
branch
from
1f80881 to
c586949
Compare
We get the following lint warning on GitHub Pull Requests:
The 'as' keyword should match the case of the 'from' keyword
FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/
Let's fix it.
Signed-off-by: Quentin Monnet <[email protected]>
This was referenced Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, add the missing probe for libelf-zstd.
Once we have that, extend the CI matrix for the build.yml workflow, in order to run a job on Ubuntu 24.04. The new probe is not enough, though: we have issues with static build using the libbfd-based disassembler. Here, we work around the issue in a dirty way: we pass all dependency flags via the
EXTRA_LDFLAGS(we need to pass-lzstdand-lsframefor libbfd, but the order of dependencies is significant and the LDFLAGS are before the deps (we could swap but don't want to, to remain close to the build feature system in the kernel).