Merged
Conversation
Instead of ignoring lines like this: `; @ pyperf.h:0` they should be treated as c-source lines in the main view but filtered out in the c source view because they don't provide any value. Previously they showed up in the main view when other c source lines did not.
theihor
approved these changes
Sep 2, 2025
Collaborator
theihor
left a comment
theihor
left a comment
There was a problem hiding this comment.
LGTM, thanks. Just one small question.
jordalgo
added a commit
to jordalgo/bpfvv
that referenced
this pull request
Sep 6, 2025
Instead of ignoring lines like this: `; @ pyperf.h:0` they should be treated as c-source lines in the main view but filtered out in the c source view because they don't provide any value. Previously they showed up in the main view when other c source lines did not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of ignoring lines like this:
; @ pyperf.h:0they should betreated as c-source lines in the main view
but filtered out in the c source view because
they don't provide any value.
Previously they showed up in the main view
when other c source lines did not.