Conversation
theihor
left a comment
theihor
left a comment
There was a problem hiding this comment.
This is a great feature, it should've been there from the start.
I am thinking the UI of the state panel needs to entice user to click, because right know it's not as obvious as with mem slots in the main view. Maybe we could add a hover hint "click to jump to the relevant write ins"? Or some visual indicator? Any ideas?
Also maybe we should switch the selected line too after a click on state panel? Because it is likely that the selected line is "far away" and there is no UI to "go back".
Screencast.From.2025-09-02.14-27-28.mp4
|
One more thing: when you click on a state row without a value, we still put the slot id in focus, even though there is nowhere to jump to. Maybe just ignore such slots? |
|
This PR closes #9 |
Let me look at improving the UI a bit.
Yeah, I was thinking about this too but I didn't like how the state panel changes if you click something in it. I do agree that it's a bit awkward to try to return to the selected line. What if we just made the "Log Line" part of the State Panel header, clickable?
Yeah, good idea. Will fix. |
Clicking on a row will update the selected state with the clicked mem slot. And scroll to the appropriate log line.
Allow clicking on Log Line and C Line which will scroll to the selected log or C line in their respective panels.
jordalgo
force-pushed
the
state_panel
branch
from
659da35 to
b5e0dbf
Compare
|
@theihor I added an additional commit to make the State Panel header interactive which should help with the need to return to the selected log line or c line. |
theihor
left a comment
theihor
left a comment
There was a problem hiding this comment.
LGTM, thank you!
I think sticking to selected line is actually good, because otherwise the state panel would change. Good idea adding "jump to line" click. We'll have to describe all this UI in the HOWTO doc.
Good call. I'll make a PR to update this. |
2 participants
Combination of two commits to make the state panel interactive and fix c source line scrollTo