Conversation
Collaborator
Author
|
One commit on top of #70 |
theihor
force-pushed
the
indirect-stack
branch
from
5d549bc to
1bdb940
Compare
jordalgo
approved these changes
Sep 4, 2025
Collaborator
jordalgo
left a comment
jordalgo
left a comment
There was a problem hiding this comment.
Overall looks good. Few minor nits.
theihor
force-pushed
the
indirect-stack
branch
from
1bdb940 to
6aae7f1
Compare
Teach analyzer to evaluate indirect stack access when computing the
array of BpfState objects.
This allows to track stack loads and stores done through a register
other than r10. For example:
*(u64 *)(r1 +0) = r8
If at this point r1 = fp-24, then the value of r8 is written there. So
far bpfvv only could detect this from verifier-provided value
changes. Now it actually checks for the value of r1 at the point of a
store, and can detect a write to fp-24 even if value expression is
absent from the log.
theihor
force-pushed
the
indirect-stack
branch
from
6aae7f1 to
3a49b7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teach analyzer to evaluate indirect stack access when computing the
array of BpfState objects.
This allows to track stack loads and stores done through a register
other than r10. For example:
If at this point r1 = fp-24, then the value of r8 is written there. So
far bpfvv only could detect this from verifier-provided value
changes. Now it actually checks for the value of r1 at the point of a
store, and can detect a write to fp-24 even if value expression is
absent from the log.
Closes #28