libbpf-cargo: Simplify build_btf_mmap() test helper#1070
Merged
danielocfb merged 1 commit intolibbpf:masterfrom Jan 21, 2025
Merged
libbpf-cargo: Simplify build_btf_mmap() test helper#1070danielocfb merged 1 commit intolibbpf:masterfrom
danielocfb merged 1 commit intolibbpf:masterfrom
Conversation
The build_btf_mmap() function is almost comically complex in what it does. In order to compile a single .bpf.c file it creates an entire Cargo Rust project and builds that, instead of simply compiling the file directly. Now that we have the BpfObjBuilder type, we can just about accomplish the latter without jumping through dozens of hoops. Do it. As a pleasant side effect of this reduction in complexity, the btf_dump test runtime more than halves: Before: $ time target/debug/deps/libbpf_cargo-37cf1fde780326f7 btf_dump > running 34 tests > [...] > ________________________________________________________ > Executed in 2.09 secs fish external After: $ time target/debug/deps/libbpf_cargo-37cf1fde780326f7 btf_dump > running 34 tests > [...] > ________________________________________________________ > Executed in 810.13 millis fish external Not the motivating factor at this point, but we take it. Signed-off-by: Daniel Müller <deso@posteo.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
build_btf_mmap()function is almost comically complex in what it does. In order to compile a single.bpf.cfile it creates an entire Cargo Rust project and builds that, instead of simply compiling the file directly. Now that we have theBpfObjBuildertype, we can just about accomplish the latter without jumping through dozens of hoops. Do it. As a pleasant side effect of this reduction in complexity, thebtf_dumptest runtime more than halves:Before:
After:
Not the motivating factor at this point, but we take it.